Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate testing scenarios for each operator #120

Merged
merged 19 commits into from
Apr 1, 2024
Merged

Separate testing scenarios for each operator #120

merged 19 commits into from
Apr 1, 2024

Conversation

adrhill
Copy link
Collaborator

@adrhill adrhill commented Mar 28, 2024

Opening this as a draft PR for feedback before updating the default scenarios in src/scenarios.

@adrhill adrhill requested a review from gdalle March 28, 2024 18:44
@gdalle gdalle marked this pull request as ready for review April 1, 2024 09:38
@gdalle
Copy link
Member

gdalle commented Apr 1, 2024

Testing

  • Create scenario types specific to each operator
  • Document most of it in the docstring of AbstractScenario
  • Add minimal type constraints in the scenario type parameters
  • Write the correct constructors
  • Apply them to the default, GPU, static and component test suites
  • Update the correctness, type stability, call count, sparsity and benchmark subroutines
  • Pass the ref_backend from above if needed to override scenario-specific reference
  • Replace @info with ProgressMeter.jl to avoid flushing the terminal

Docs

  • Create TOC sections on the sidebar
  • Separate core and testing API references
  • Separate extensions from backends

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 98.31461% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.54%. Comparing base (78d3d99) to head (88128c1).

Files Patch % Lines
...entiationInterfaceTest/src/test_differentiation.jl 91.17% 3 Missing ⚠️
...DifferentiationInterfaceTest/src/tests/sparsity.jl 80.00% 2 Missing ⚠️
...fferentiationInterfaceTest/src/tests/call_count.jl 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   93.76%   94.54%   +0.78%     
==========================================
  Files          59       59              
  Lines        1828     1798      -30     
==========================================
- Hits         1714     1700      -14     
+ Misses        114       98      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 3bfcd1f into main Apr 1, 2024
2 checks passed
@gdalle gdalle deleted the ah/test-table branch April 1, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants