-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove implem, add prepare #30
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 96.15% 96.19% +0.04%
==========================================
Files 21 21
Lines 338 342 +4
==========================================
+ Hits 325 329 +4
Misses 13 13 ☔ View full report in Codecov by Sentry. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/DifferentiationInterface.jl/DifferentiationInterface.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job: Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/DifferentiationInterface.jl/DifferentiationInterface.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/DifferentiationInterface.jl/DifferentiationInterface.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
@@ -35,7 +35,23 @@ Whenever it makes sense, four variants of the same operator are defined: | |||
|
|||
Replace `something` with `derivative`, `multiderivative`, `gradient`, `jacobian`, `pushforward` or `pullback` to get the correct name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's emphasize this with an admonition (I personally read over it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe change "primal too" to "primal and differential", or at least swap the rows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: "primal and differential"
Source
CustomImplem() / FallbackImplem()
dispatch mechanism (src/implem.jl
): the backend operator will always be selected if it existssrc/prepare.jl
) to create theextras
object with six functions:prepare_pushforward
,prepare_pullback
,prepare_derivative
,prepare_multiderivative
,prepare_gradient
andprepare_jacobian
nothing
by default (for now)MethodError
if they get something else thannothing
(for now)Docs
Tests
implem
stuff(extras,)
as a trailingargs...
Benchmarks
implem
stuffextras
object is notnothing