Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust hessian-vector products #53

Closed
gdalle opened this issue Mar 17, 2024 · 3 comments
Closed

More robust hessian-vector products #53

gdalle opened this issue Mar 17, 2024 · 3 comments

Comments

@gdalle
Copy link
Member

gdalle commented Mar 17, 2024

Right now the function gradient_and_hessian_vector_product requires differeniating through a f!(y, x) with the inner backend. This is not possible for every backend, so we should have another trait layer that dispatches on whether or not the backend handles mutating function

@gdalle
Copy link
Member Author

gdalle commented Mar 18, 2024

Necessary trait introduced in #55

@gdalle gdalle changed the title HVP for everyone More robust hessian-vector products Mar 18, 2024
@gdalle
Copy link
Member Author

gdalle commented Mar 18, 2024

Also problematic is the fact that the test suite doesn't hit every line of that file yet

@gdalle
Copy link
Member Author

gdalle commented Mar 21, 2024

Fixed by #83, closing in favor of more specific issues

@gdalle gdalle closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant