Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fully non-allocating for zero backends #58

Closed
gdalle opened this issue Mar 18, 2024 · 1 comment
Closed

Get fully non-allocating for zero backends #58

gdalle opened this issue Mar 18, 2024 · 1 comment

Comments

@gdalle
Copy link
Member

gdalle commented Mar 18, 2024

At the moment there are still broken tests.
Some of them seem to depend on the benchmarking functions themselves, like multiderivative! with AutoZeroReverse.
When you remove the function evaluation, it passes, even though the function in every mutating scenario is supposed to be allocation-free.
Even weirder, when you remove just the second line of f!_scalar_vector, it passes as well.
Maybe something to do with inlining?

@gdalle
Copy link
Member Author

gdalle commented Mar 19, 2024

So I figured it out in #75

I think small enough functions were not affected by this because they were inlined

@gdalle gdalle closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant