Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eras mode #263

Merged
merged 29 commits into from
Apr 9, 2024
Merged

Eras mode #263

merged 29 commits into from
Apr 9, 2024

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Feb 6, 2024

Closes #252

  • changes to the internals
  • hooking up for forward_demand
  • tests

@oxinabox
Copy link
Member Author

I have started adding tests but right now they show no change unnested,
and once we nest type inference is failing with or without eras mode being turned on.
So that needs to be fixed.
I suspect it is because I am using a if statement rather than a seperate method, in shuffle_up

src/stage1/forward.jl Outdated Show resolved Hide resolved
@oxinabox oxinabox marked this pull request as ready for review April 5, 2024 17:15
@oxinabox oxinabox requested review from Keno and aviatesk April 5, 2024 17:15
@oxinabox
Copy link
Member Author

oxinabox commented Apr 5, 2024

A question for the reviewer.
Is this a breaking change?
It doesn't break the public API. and technically doesn't break calling the private ∂☆{1}()(...) API
So I guess not?

@oxinabox
Copy link
Member Author

oxinabox commented Apr 5, 2024

idk why CI isn't working on 1.11, it is complaining it can't compile Cthulhu.

On 1.10 it is because the code for running inference manually (which we do in the tests) is wrong, and idk how to do it right. (can probably work it out though).

@oxinabox
Copy link
Member Author

oxinabox commented Apr 8, 2024

@oxinabox
Copy link
Member Author

oxinabox commented Apr 9, 2024

fixed everything, this is now just waiting for review

Copy link
Collaborator

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@oxinabox oxinabox merged commit 80660ad into main Apr 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eras mode: Taylor or it Eras
3 participants