stage1: Mark partial and primal helpers as @inline
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear whether this is a compiler bug upstream, but I've observed
invokes like this in the wild:
```
%xxx = invoke DAECompiler.partial(%135::Diffractor.TangentBundle{1}, 1::Int64)::Any
```
which are (clearly) very poorly typed. `%135` was a fully concrete type,
so I'm not sure why the tangent type parameters ended up getting
stripped off.
In any case, the implementations here are so small that they are
probably best just inlined anyway.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 54.92% 54.12% -0.81%
==========================================
Files 27 27
Lines 3026 2997 -29
==========================================
- Hits 1662 1622 -40
- Misses 1364 1375 +11 ☔ View full report in Codecov by Sentry. |
oxinabox
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear whether this is a compiler bug upstream, but I've observed invokes like this in the wild:
which are (clearly) very poorly typed.
%135was a fully concrete type, so I'm not sure why the tangent type parameters ended up getting stripped off for the invoke.In any case, the implementations here are so small that they are probably best just inlined anyway.