Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: What is the point of NODELABELSIZE and other capitalized kwargs? #177

Open
hdavid16 opened this issue Jul 26, 2022 · 0 comments · May be fixed by #180
Open

Question: What is the point of NODELABELSIZE and other capitalized kwargs? #177

hdavid16 opened this issue Jul 26, 2022 · 0 comments · May be fixed by #180

Comments

@hdavid16
Copy link
Contributor

I see that these are used for converting from relative sizes to absolute sizes. Why not just use absolute sizes in the first place? I think having two keyargs with the same name but different capitalization is just redundant and sometimes confusing.

I can put together a PR that switches to just absolute sizes if desired.
hdavid16 added a commit to hdavid16/GraphPlot.jl that referenced this issue Jul 27, 2022
@hdavid16
update arg syntax for gplot: (address JuliaGraphs#177)
d610f15 
-breaking change: linetype changed from String to Symbol
-breaking change: default for edgelabel is nothing (not []) to make consistent with nodelabel default
-remove all caps args
-improve some of the code in gplot (use isnothing, etc.)
@hdavid16 hdavid16 changed the title Question: What is the point of NODELABELSIZE and NODELABELSIZE? Question: What is the point of NODELABELSIZE and other capitalized kwargs? Aug 2, 2022
@hdavid16 hdavid16 linked a pull request Aug 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve arg syntax for gplot and cleanup repo hdavid16/GraphPlot.jl
1 participant
@hdavid16