-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jldsave function API #297
jldsave function API #297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.02%
==========================================
Files 26 26
Lines 2641 2647 +6
==========================================
+ Hits 2385 2391 +6
Misses 256 256
Continue to review full report at Codecov.
|
hmm, I like this syntax a lot, but I'm starting to think that it might be more useful to add it to the FileIO API (as an alternative zero-argument method). After all, it does basically the same thing (store key-value pairs in a JLD2 file) and I personally think the current |
A compatible workaround to JuliaIO/FileIO.jl#324: fileio_save(f::File{format"JLD2"}, ::Nothing; kwargs...) = jldsave(FileIO.filename(f); kwargs...) and use |
Thank you for the suggestion but I'm not convinced. |
JuliaIO/FileIO.jl#324 is a breaking change so even if it's approved, it needs time to adopt. Before that actually get supported, |
This PR adds a new API function that leverages julia's keyword argument syntax.