-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation? #6
Comments
Maybe for starters just a basic example given a |
That's a good idea. The examples can be copied from the test files. PRs are welcome ;) |
I should maybe add, @axsk, that while the functionality in here is certainly useful more generally, the package is a helper package for Optim and NLsolve, so some of the API might seem a bit alien if you're not familiar with the codebases in those packages. |
Any updates on this? It would be great to have documentation on how to use the package outside of Optim and NLsolve. |
We are in the middle of transitioning the code to a more "non-Optim-friendly" API. See #90 It should be quite straight-forward to introduce some examples for usage when we are finished with that. EDIT: Both @pkofod and I are quite busy with other things this month, but I hope to have some time in June to sort out some missing JuliaNLSolvers things. |
I just want to chime in: it's actually the right approach to bump :) We're just super busy, and not many people have actually contributed to this package or have a clear idea where it's going, so you'll either have to help us out, or wait a bit longer. As Asbjørn said, we're both facing somewhat hard constraints and deadlines outside of OSS development, but nothing is abandoned. |
i want to contribute, if its possible, what can i do? |
Hi @longemen3000, thank you for the interest in helping out :) NB: I have little knowledge of the current needs of the JuliaNLSolvers group, @pkofod can probably direct you more efficiently in the best direction Are you particularly interested in contributing to the documentation, or more generally? If documentation:
If any type of contribution:
|
i forked the package and i'm standarizing the code (changing convert(T,0) to zero(T), convert(T,1) to one(T), etc. the next step is standarizing the interpolation functions used in the package (quadratic,, etc), an trying to eliminate repeated code |
Looking forward to seeing what you come up with, but keep in mind that someone has to read the diffs/change, so it's often much easier to get something merged if you stick to one specific change at a time. I'd rather have one for the converts, one for the quadratic roots, etc, than one giant PR that has many great changes but are difficult to isolate and review. |
Hi @longemen3000 If you're working on this, please reach out to me on slack, discourse or if you can find my e-mail. I want to make sure you're not doing anything that will be voided by near-future changes to all of JuliaNLSolvers. |
I'm trying to figure out how to set a maximum step length when optimizing with Optim, but it's quite hard. The keyword arguments to the different line-search methods do not seem to be documented, and poking around in the code I sometimes find @with_kw struct HagerZhang{T, Tm}
...
alphamax::T = Inf @with_kw struct InitialHagerZhang{T}
...
αmax::T = Inf Should I set one of those? |
Hi @baggepinnen, is this to use with Optim or with a different package? The The initial step length functionality is a pre-process step, you can find out how it's used in the Optim source code. If you need to use the InitialHagerZhang procedure to decide the initial step length, then you should also set αmax. Disclaimer: I haven't used this package / Julia for nearly two years. |
There's no uniform interface across all options here I'm afraid, but yes I think alphamax is what you want. But to repeat Asbjørn's question, what are you doing more specifically?
But you're still faster than me on wrt help desk tasks. I like it :) |
My contribution to the documentation is to explain what I don't get. It looks as if the central operation is Among the semantic questions is whether the search is seeking to minimize or maximize the objective function (or is it looking for a zero?). Some discussion of automatic differentiation would also be helpful; again, maybe a reference to |
We should create documentation, or at the very least explain the input and output structure for the linesearch algorithms.
The text was updated successfully, but these errors were encountered: