Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate UnconstrainedProblems / add getproblem API #10

Open
anriseth opened this issue Feb 16, 2018 · 4 comments
Open

Deprecate UnconstrainedProblems / add getproblem API #10

anriseth opened this issue Feb 16, 2018 · 4 comments

Comments

@anriseth
Copy link
Collaborator

Ref #9 (comment)

@pkofod
Copy link
Member

pkofod commented Feb 16, 2018

Yes, that's exactly what I mean. If you tag this package now, Optim will break, so you have to put an upper bound on Optim and that's annoying. Or am I misunderstanding?

@anriseth
Copy link
Collaborator Author

It won't break, as I added backwards-compatibility in the PR. See, for example, https://github.com/JuliaNLSolvers/OptimTestProblems.jl/blob/master/src/OptimTestProblems.jl#L8. The annoying thing is that I don't know how to tell the user to stop using the legacy stuff.

@pkofod
Copy link
Member

pkofod commented Feb 16, 2018

Ah, perfect then! Anyway, we're the only users here. The lesson is to use something like getproblem() instead of dictionaries for stuff like this. If something could be deprecated at some point, it's always better to use a function.

@anriseth anriseth changed the title Deprecate UnconstrainedProblems Deprecate UnconstrainedProblems / add getproblem API Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants