Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpiexec() do syntax recommended in docs but deprecated after julia 1.6 #786

Closed
mmesiti opened this issue Oct 30, 2023 · 1 comment · Fixed by #787
Closed

mpiexec() do syntax recommended in docs but deprecated after julia 1.6 #786

mmesiti opened this issue Oct 30, 2023 · 1 comment · Fixed by #787

Comments

@mmesiti
Copy link
Contributor

mmesiti commented Oct 30, 2023

https://github.com/JuliaParallel/MPI.jl/blob/master/docs/src/usage.md suggests using

mpiexec() do exe  # MPI wrapper
        run(`$exe -n $n $(Base.julia_cmd()) [...]/01-hello.jl`)
        # alternatively:
        # p = run(ignorestatus(`...`))
        # @test success(p)
    end

but this causes a deprecation warning (at least in Julia 1.9.3). The inline documentation says that

run(`$(mpiexec()) $arguments`)

is threadsafe and should be preferred.

@simonbyrne
Copy link
Member

Would you mind opening a pull request?

mmesiti added a commit to mmesiti/MPI.jl that referenced this issue Oct 30, 2023
@giordano giordano linked a pull request Oct 30, 2023 that will close this issue
giordano pushed a commit that referenced this issue Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants