Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tests / Increase code coverage in tests #107

Open
lmh91 opened this issue Nov 19, 2020 · 3 comments
Open

Refactor Tests / Increase code coverage in tests #107

lmh91 opened this issue Nov 19, 2020 · 3 comments
Assignees
Milestone

Comments

@lmh91
Copy link
Collaborator

lmh91 commented Nov 19, 2020

At the moment, we are simulating quite a number of detectors in our tests.
We should reduce that.

I guess besides the comparison to analytic solutions we only need to simulate 2 real detectors.
One for cartesian and one for cylindrical coordinates.

We should add then smaller, more specific tests for the geometry, e.g., primitives.
But we don't need a full simulation for each primitive.

@schustermartin
Copy link
Collaborator

I second this.

I think there still should be a test script that basically runs every single feature and function we have to offer. This should be made available in the package but not as the one that is run automatically. People can run it locally for somewhat larger PRs to ensure nothing really breaks.

@fhagemann
Copy link
Collaborator

This is already in the making!
#122 already has script that tests primitives, transformations, sets and read-in.
Whenever we merge the new CSG with the already existing simulation code, the current and new test scripts can be combined.

@fhagemann fhagemann added this to the v0.6.0 milestone Jul 14, 2021
@lmh91 lmh91 removed this from the v0.6.0 milestone Jul 28, 2021
@fhagemann fhagemann added this to the v0.6.1 milestone Jul 28, 2021
@fhagemann
Copy link
Collaborator

We should create "Test detector" for this covering basically all cases. This should be a dedicated PR tough.

Originally posted by @lmh91 in #206 (comment)

@lmh91 lmh91 removed this from the v0.6.x milestone Sep 7, 2021
@fhagemann fhagemann changed the title Refactor Tests Refactor Tests / Increase code coverage in tests Oct 27, 2021
@lmh91 lmh91 linked a pull request Feb 7, 2022 that will close this issue
@fhagemann fhagemann added this to the v0.11.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants