From 12008ef1c651ac33f980a2ae65bead7050fcc031 Mon Sep 17 00:00:00 2001 From: Michael Krabbe Borregaard Date: Mon, 13 Aug 2018 10:07:03 +0200 Subject: [PATCH] Don't broadcast plot_color; fix #1641 On 1.0 you can no longer pass a singleton argument to broadcast without escaping with `Ref`. But - `plot_color` has `Vector` methods, so it should be fine to not broadcast here. The example from the PR that introduced the broadcast here still works on this PR https://github.com/JuliaPlots/Plots.jl/pull/1467#issue-178940271 --- src/args.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/args.jl b/src/args.jl index a63101701..6b2dd4cda 100644 --- a/src/args.jl +++ b/src/args.jl @@ -1569,13 +1569,13 @@ function _update_series_attributes!(d::KW, plt::Plot, sp::Subplot) for s in (:line, :marker, :fill) csym, asym = Symbol(s,:color), Symbol(s,:alpha) d[csym] = if d[csym] == :auto - plot_color.(if has_black_border_for_default(d[:seriestype]) && s == :line + plot_color(if has_black_border_for_default(d[:seriestype]) && s == :line sp[:foreground_color_subplot] else d[:seriescolor] end) elseif d[csym] == :match - plot_color.(d[:seriescolor]) + plot_color(d[:seriescolor]) else getSeriesRGBColor.(d[csym], Ref(sp), plotIndex) end