-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature to change x-axis order for boxplots #483
Conversation
@Tobias-Thomas thank you for the contribution, and I'm very sorry for the late review! I know I recommended the keyword |
Oh, no problem. The only other idea, I would have is |
I was searching for a way to sort boxplots, but still is not solved or I am wrong?, is there a way I can help to fix this? |
The fix I implemented was essentially quite easy, but as you can see above, we were still unsure about the name of this parameter, and I think we need a JuliaPlots member to decide on that. |
What about order to keep a similar idea like seaborn, sort_labels_by also can be OK, sort_x_by can be a little bit confused if later there is an implementation using horizontal boxplots. |
Yea, I understand that point. Out of those options, I would prefer |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 26.52% 26.52%
=======================================
Files 20 20
Lines 1248 1248
=======================================
Hits 331 331
Misses 917 917
☔ View full report in Codecov by Sentry. |
@sethaxen, I updated the name and merged it into the current master. Is there anything left to do for me in this PR? |
Hi, any updates on this? I'm running into this issue while trying to figure out how to sort the x axis in a boxplot. |
I think the fix would be ready for merge, but I do not know who to ping, to review the PR.. |
Maybe @sethaxen , can help us with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Tobias-Thomas for the delay! Everything looks good to me! Thanks!
So how do I use sort_labels_by now? Can I just put in an order for the x axis like: |
No, the function uses the same interface as |
Can someone please explain how the category sorting for boxplots now works? It is not quite clear to me from the previous comment. Would be nice to see an example. Thanks! |
Ok, I think I got it. The example below explains the logic. It worked for me.
It would be nice to have a similar parameter for the violin plot. |
Before this PR the way to do that was to use |
Fixes #409, by adding
by
as a new optional parameter to boxplots. Thisby
is the same, one would use forsort
. It's default parameter is theidentity
.Before merge, can someone please tell me, where I can add the documentation for this new parameter?
Thanks in advance.