Make @df support string column names #563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaPlots#562. Add a special case to `add_sym!` to convert an `AbstractString` column name to a `Symbol` before adding it. The old behavior would iterate over the string and try to add each character as a column name. This produced a stack overflow, since `add_sym!` had no special case for `Char`, resulting in indefinite recursion.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 26.52% 26.44% -0.09%
==========================================
Files 20 20
Lines 1248 1248
==========================================
- Hits 331 330 -1
- Misses 917 918 +1 ☔ View full report in Codecov by Sentry. |
|
Merged via JuliaPlots/Plots.jl#5033. |
|
I mean, if you want it pre 2.0 it should be merged here as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562. Add a special case to
add_sym!to convert anAbstractStringcolumn name to aSymbolbefore adding it.The old behavior would iterate over the string and try to add each character as a column name. This produced a stack overflow, since
add_sym!had no special case forChar, resulting in indefinite recursion.