Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fused multiply-add (Base.fma) support for Num #1013

Open
nsajko opened this issue Nov 19, 2023 · 1 comment
Open

Fused multiply-add (Base.fma) support for Num #1013

nsajko opened this issue Nov 19, 2023 · 1 comment

Comments

@nsajko
Copy link
Contributor

nsajko commented Nov 19, 2023

Currently trying to use fma on Symbolics variables (Num) fails. This should be supported, I think.

Given that Num can contain either symbolic or numeric values, fma for Nums can behave differently depending on whether some arguments are symbolic:

  1. Delegate to muladd if any of the three Num arguments to fma is symbolic.
  2. Otherwise (if all of the arguments are numeric) use fma on the unwrapped numeric values and return a Num that wraps the result thus obtained.
@ChrisRackauckas
Copy link
Member

I would think this just needs to get registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants