-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove type
argument, symtype
, update docs
#39
Conversation
type
argumenttype
argument, symtype
, update docs
Was there an agreement on this? |
I will file a reviewable PR with the needed changes to SU |
@bowenszhu you've been considering the performance semantics, what do you think of this? |
Also, is this actually correct? How is the type used in the hash if it's in the metadata? |
This doesn't bother with performance.
Probably fine. In SymbolicUtils.jl,
|
If that's the case then it should just use: @assume_effects :total __parameterless_type(T)=Base.typename(T).wrapper
parameterless_type(x) = parameterless_type(typeof(x))
parameterless_type(x::Type) = __parameterless_type(x) |
#36