Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out PROBE #376

Closed
1 of 3 tasks
pat-alt opened this issue Dec 13, 2023 · 0 comments · Fixed by #492 · May be fixed by #371
Closed
1 of 3 tasks

Sort out PROBE #376

pat-alt opened this issue Dec 13, 2023 · 0 comments · Fixed by #492 · May be fixed by #371
Labels
bug Something isn't working enhancement New feature or request

Comments

@pat-alt
Copy link
Member

pat-alt commented Dec 13, 2023

Let's revisit the PROBE paper and double-check if the hinge-loss function is correctly defined. For consistency, I also think invalidation rate should not be a separate convergence criterium but handled through generator conditions.

  • double-check PROBE loss function (see first observation below)
  • Sort out nested AD problem
  • invalidation rate as generator condition

Observations

  1. Currently gradients are simply not computed with respect to the Hinge loss. The desired invalidation rate is attained simply as a by-product of continuing the standard counterfactual search.
  2. There actually is an open-source implementation now: https://github.com/MartinPawel/ProbabilisticallyRobustRecourse/blob/main/carla/recourse_methods/catalog/w_rip/library/wachter_rip.py#L46
  3. The nested gradient computation simply won't work with Zygote, so need to consider other things like Use Enzyme or DifferentiationInterface for autodiff #300 (see here and here for relevant threads)
@pat-alt pat-alt added the enhancement New feature or request label Dec 13, 2023
@pat-alt pat-alt linked a pull request Dec 13, 2023 that will close this issue
2 tasks
@pat-alt pat-alt mentioned this issue Oct 30, 2024
1 task
@pat-alt pat-alt added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant