Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTorch tests #7

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add PyTorch tests #7

merged 3 commits into from
Nov 14, 2023

Conversation

kmariuszk
Copy link
Collaborator

@kmariuszk kmariuszk commented Nov 13, 2023

Testing functionality of PyTorch models.

@kmariuszk kmariuszk requested a review from pat-alt November 13, 2023 11:58
@kmariuszk
Copy link
Collaborator Author

@pat-alt could you please take a look at the error message thrown by the pipelines Julia1.7 and Julia1.8? It popped up after I added

using PackageExtensionCompat
function __init__()
    @require_extensions
end

in the src/TaijaInteroperability.jl folder. My best guess why it pops up is the fact that I didn't create Project.toml in the test folder and handled the dependencies in the root Project.toml file. Do you think that's the case? Or am I missing something else?

@pat-alt
Copy link
Member

pat-alt commented Nov 13, 2023

@pat-alt could you please take a look at the error message thrown by the pipelines Julia1.7 and Julia1.8? It popped up after I added

using PackageExtensionCompat
function __init__()
    @require_extensions
end

in the src/TaijaInteroperability.jl folder. My best guess why it pops up is the fact that I didn't create Project.toml in the test folder and handled the dependencies in the root Project.toml file. Do you think that's the case? Or am I missing something else?

Exactly, just create a separate env for tests in the test folder and add those deps

@kmariuszk kmariuszk requested review from pat-alt and removed request for pat-alt November 14, 2023 16:18
Copy link
Member

@pat-alt pat-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kmariuszk kmariuszk merged commit 83edc67 into main Nov 14, 2023
4 checks passed
@kmariuszk kmariuszk deleted the Test-PyTorch branch November 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants