From 5029dd00136d4f1fb5f24e848fd740b9825cc07d Mon Sep 17 00:00:00 2001
From: Julien <julien@ripouteau.com>
Date: Fri, 20 Sep 2024 16:25:26 +0200
Subject: [PATCH] fix: memory lock owner not updated

---
 packages/verrou/src/drivers/memory.ts |  1 +
 packages/verrou/src/test_suite.ts     | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/packages/verrou/src/drivers/memory.ts b/packages/verrou/src/drivers/memory.ts
index ecbf58c..0c5fcba 100644
--- a/packages/verrou/src/drivers/memory.ts
+++ b/packages/verrou/src/drivers/memory.ts
@@ -88,6 +88,7 @@ export class MemoryStore implements LockStore {
     if (mutex.owner !== owner) throw new E_LOCK_NOT_OWNED()
 
     mutex.releaser()
+    this.#locks.delete(key)
   }
 
   /**
diff --git a/packages/verrou/src/test_suite.ts b/packages/verrou/src/test_suite.ts
index 2a56fdc..b425add 100644
--- a/packages/verrou/src/test_suite.ts
+++ b/packages/verrou/src/test_suite.ts
@@ -149,6 +149,28 @@ export function registerStoreTestSuite(options: {
     assert.deepEqual(result, '42')
   })
 
+  test('run is exclusive with two factories', async ({ assert }) => {
+    const provider = new LockFactory(options.createStore())
+    const lock1 = provider.createLock('foo')
+    const lock2 = provider.createLock('foo')
+
+    let flag = false
+    lock1.run(async () => {
+      await sleep(500)
+      flag = true
+    })
+
+    assert.isFalse(flag)
+
+    const [, result] = await lock2.run(async () => {
+      assert.isTrue(flag)
+      return '42'
+    })
+
+    assert.isTrue(flag)
+    assert.deepEqual(result, '42')
+  })
+
   test('exceptions during run do not leave mutex in locked state', async ({ assert }) => {
     const provider = new LockFactory(options.createStore())
     const lock = provider.createLock('foo')