Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRCode login #2918

Open
7 tasks done
Outzzz opened this issue Jun 19, 2023 · 2 comments
Open
7 tasks done

QRCode login #2918

Outzzz opened this issue Jun 19, 2023 · 2 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@Outzzz
Copy link

Outzzz commented Jun 19, 2023

Checklist

Enhancement purpose

is it possible to implement qr code login?

Solution

Why currently available solutions are not sufficient?

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

No response

@Outzzz Outzzz added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 19, 2023
@JustArchi
Copy link
Member

Yes, it's possible, as xPaw also finished implementation of QR codes in SK2, with example here: https://github.com/SteamRE/SteamKit/blob/master/Samples/1b.QrCodeAuthentication/Program.cs

Doing it right would involve a prompt like we have currently for device confirmation whether or not user wants to log in using QR code, then in loop printing new code on the console for whole duration, because it changes each 30 seconds or so. On top of that we need a way to expose QR code using IPC e.g. for ASF-ui so it can display the code and allow users to log in using headless modes. This would add yet another layer of complexity, as ASF needs to know whether or not QR code should be used, so proper implementation for that should be a way for ASF-ui to ask user whether he wants to confirm by phone, qr code, or use the code, and add logic in ASF to make use of it.

Crapload of work for doing it right and little gain for user convenience. It's not invalid issue, but it's hardly something I plan to work on since I have zero motivation for it where superior solutions like ASF 2FA exist, for everybody, even people without rooted phones. I'm putting it on no priority wishlist, if somebody wants to code it for me, be my guest, but expect rocky road.

@JustArchi JustArchi added 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 19, 2023
@GustavoSchip

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ⚪ No priority Issues marked with this label are not being actively worked on for time being. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

3 participants