Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCN] added Danyang vc translation #822

Closed
wants to merge 3 commits into from

Conversation

yang85
Copy link
Contributor

@yang85 yang85 commented Feb 14, 2024

Added some voice line translation for DanYang

@sinsinpub
Copy link
Contributor

scn? i think u have misunderstood... /tctn not the Simplified Chinese folder, should be /scn. tctn might be the unused ver of /tcn-yue

@yang85 yang85 closed this Feb 14, 2024
@yang85 yang85 deleted the scn/danyang/021324 branch February 14, 2024 05:24
@yang85
Copy link
Contributor Author

yang85 commented Feb 14, 2024

Branched from the wrong branch, see #823

@sinsinpub
Copy link
Contributor

still didn't get me...? should edit the /scn/quotes.json file instead of /tctn/quotes.json.
u can see all the characters around ur modifications are 繁体字
image

@yang85
Copy link
Contributor Author

yang85 commented Feb 14, 2024

for some reason my scn wasn't updated and the wrong one was loaded, fixing it rn

@yang85
Copy link
Contributor Author

yang85 commented Feb 14, 2024

update, Thanks for double-checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants