Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Russian comments to UTF-8 or re-write them in English #1

Open
xplt opened this issue Mar 12, 2024 · 1 comment
Open

Convert Russian comments to UTF-8 or re-write them in English #1

xplt opened this issue Mar 12, 2024 · 1 comment

Comments

@xplt
Copy link

xplt commented Mar 12, 2024

I took a quick glimpse at the code and I see that it uses CP1251 encoding for both comments and the code. For example,

Comments (in many-many places, these are just a few examples):

Code: https://github.com/KD-lab-Open-Source/qdEngine/blob/main/src/QD/Core/System/app_error_handler.cpp#L15

I think, it should be either converted to UTF-8 (not sure if it's possible, if it is being used in code as well) or to be re-written in English

@ivan-ushakov
Copy link

Yes, converting to UTF-8 is preferable. Unfortunately some files have broken encoding, like qdEngine/src/XLibs/Util/XMath/XMath.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants