update workflows

- update runner versions - update compiler version - update clang-tidy version - fix new clang-tidy warnings - re-enable core guidelines checker - remove iwyu - add custom latch implementation to avoid issues with libstdc++ atomic wait/notify implementation on arm64 - fix ARM issues in general
KRM7 · Sep 4, 2024 · 8b4dc4a · 8b4dc4a
1 parent 76299ea
commit 8b4dc4a
Show file tree

Hide file tree

Showing 35 changed files with 221 additions and 206 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -30,16 +30,19 @@
   -readability-uppercase-literal-suffix,
   -readability-braces-around-statements,
   -bugprone-easily-swappable-parameters,
+  -bugprone-unchecked-optional-access,
   -cppcoreguidelines-special-member-functions,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-non-private-member-variables-in-classes,
   -cppcoreguidelines-prefer-member-initializer,
+  -cppcoreguidelines-missing-std-forward,
   -cppcoreguidelines-narrowing-conversions,
   -cppcoreguidelines-avoid-non-const-global-variables,
   -misc-non-private-member-variables-in-classes,
   -misc-no-recursion,
   -misc-const-correctness,
-  -misc-use-anonymous-namespace
+  -misc-use-anonymous-namespace,
+  -misc-include-cleaner
 
 
 # Also check the header files

diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml
@@ -0,0 +1,15 @@
+name: "CodeQL config"
+
+queries:
+  - uses: security-and-quality
+
+query-filters:
+  - exclude:
+      id: cpp/include-non-header
+  - exclude:
+      id: cpp/undisciplined-multiple-inheritance
+  - exclude:
+      id: cpp/unused-static-variable
+  - exclude:
+      id: cpp/missing-return
+
diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml
@@ -6,8 +6,6 @@ jobs:
   core-guidelines:
     name: core-guidelines-check
     runs-on: windows-2022
-    # Disabled because of an internal compiler error in reference_lines.cpp
-    if: false
 
     defaults:
       run:
@@ -37,24 +35,23 @@ jobs:
 #############################################################################################################
 
   clang-analyzers:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
         tool: [
-            { name: iwyu,       cmake-flag: CMAKE_CXX_INCLUDE_WHAT_YOU_USE="iwyu;-Xiwyu;--mapping_file=../.iwyu-mappings" },
             { name: clang-tidy, cmake-flag: CMAKE_CXX_CLANG_TIDY="clang-tidy" },
             { name: cppcheck,   cmake-flag: CMAKE_CXX_CPPCHECK="cppcheck;--version;--verbose;--report-progress;--enable=all;--error-exitcode=1;--std=c++20;--suppressions-list=../.cppcheck-supressions" }
         ]
         include:
-          - pkgs: clang-15 clang-tools-15 clang-tidy-15 iwyu cppcheck
-            cxx: clang++-15
+          - pkgs: clang-18 clang-tools-18 clang-tidy-18 iwyu cppcheck
+            cxx: clang++-18
 
     defaults:
       run:
         working-directory: ${{ github.workspace }}/build
 
-    name: ${{ matrix.tool.name }}
+    name: ${{ matrix.tool.name }} (${{ matrix.cxx }})
 
     steps:
       - name: checkout-repo
@@ -79,15 +76,15 @@ jobs:
 #############################################################################################################
 
   codeql:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     strategy:
       matrix:
         include:
-          - pkgs: clang-15
-            cxx: clang++-15
+          - pkgs: clang-18
+            cxx: clang++-18
 
-    name: codeql
+    name: codeql (${{ matrix.cxx }})
 
     defaults:
       run:
@@ -104,7 +101,7 @@ jobs:
         uses: github/codeql-action/init@v3
         with:
           languages: cpp
-          queries: security-and-quality
+          config-file: ${{ github.workspace }}/.github/codeql/codeql-config.yml
 
       - name: setup-build
         env:

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   update-docs:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     defaults:
       run:
         working-directory: ${{ github.workspace }}

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -4,17 +4,23 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
+    container:
+      image: ubuntu:24.04
     strategy:
       fail-fast: false
       matrix:
+        common-pkgs: [ git cmake ]
         build-type: [ Release, RelWithDebInfo ]
         compiler: [
             { cxx: g++-11, pkgs: g++-11 },
             { cxx: g++-12, pkgs: g++-12 },
             { cxx: g++-13, pkgs: g++-13 },
-            { cxx: clang++-14, pkgs: clang-14 libstdc++6=12.3.0-1ubuntu1~22.04 libgcc-s1=12.3.0-1ubuntu1~22.04 },
+            { cxx: g++-14, pkgs: g++-14 },
             { cxx: clang++-15, pkgs: clang-15 },
+            { cxx: clang++-16, pkgs: clang-16 },
+            { cxx: clang++-17, pkgs: clang-17 },
+            { cxx: clang++-18, pkgs: clang-18 },
         ]
 
     defaults:
@@ -28,17 +34,17 @@ jobs:
       uses: actions/checkout@v4
 
     - name: setup-compiler
-      run: sudo apt update && sudo apt install --allow-downgrades -y ${{ matrix.compiler.pkgs }}
+      run: apt update && apt install --allow-downgrades -y ${{ matrix.common-pkgs }} ${{ matrix.compiler.pkgs }}
 
     - name: setup-catch
       env:
         CXX: ${{ matrix.compiler.cxx }}
-      run: sudo bash ../tools/install_catch.sh
+      run: bash ../tools/install_catch.sh
 
     - name: setup-build
       env:
         CXX: ${{ matrix.compiler.cxx }}
-      run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_USE_WERROR=ON -DGAPP_USE_LTO=ON
+      run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_USE_WERROR=ON -DGAPP_USE_LTO=ON -DGAPP_CXX_FLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS"
 
     - name: build
       run: cmake --build . --parallel 8
@@ -47,4 +53,4 @@ jobs:
       run: ctest --output-on-failure --schedule-random
 
     - name: install
-      run: sudo cmake --install .
+      run: cmake --install .
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -4,26 +4,39 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: macos-13
+    runs-on: macos-14
     strategy:
       fail-fast: false
       matrix:
         build-type: [ Release, RelWithDebInfo ]
         compiler: [
-            { cxx: g++-11, pkgs: gcc@11, extra-flags: "-undefined dynamic_lookup" },
-            { cxx: g++-12, pkgs: gcc@12, extra-flags: "-undefined dynamic_lookup" },
-            { cxx: g++-13, pkgs: gcc@13, extra-flags: "-undefined dynamic_lookup -Wno-array-bounds -Wno-stringop-overflow -Wno-stringop-overread" },
+            { cxx: g++-11, pkgs: gcc@11, extra-flags: "-undefined dynamic_lookup -Wno-psabi" },
+            { cxx: g++-12, pkgs: gcc@12, extra-flags: "-undefined dynamic_lookup -Wno-psabi" },
+            { cxx: g++-13, pkgs: gcc@13, extra-flags: "-undefined dynamic_lookup -Wno-psabi" },
+            { cxx: g++-14, pkgs: gcc@14, extra-flags: "-undefined dynamic_lookup -Wno-psabi" },
             {
-              cxx: $(brew --prefix llvm@14)/bin/clang++,
-              pkgs: llvm@14 gcc@11,
-              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@11)/include/c++/11 -cxx-isystem $(brew --prefix gcc@11)/include/c++/11/x86_64-apple-darwin22",
+              cxx: $(brew --prefix llvm@15)/bin/clang++,
+              pkgs: llvm@15 gcc@11,
+              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@11)/include/c++/11 -cxx-isystem $(brew --prefix gcc@11)/include/c++/11/aarch64-apple-darwin23",
               linker-flags: "-L$(brew --prefix gcc@11)/lib/gcc/11"
             },
             {
-              cxx: $(brew --prefix llvm@15)/bin/clang++,
-              pkgs: llvm@15 gcc@12,
-              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@12)/include/c++/12 -cxx-isystem $(brew --prefix gcc@12)/include/c++/12/x86_64-apple-darwin22",
+              cxx: $(brew --prefix llvm@16)/bin/clang++,
+              pkgs: llvm@16 gcc@12,
+              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@12)/include/c++/12 -cxx-isystem $(brew --prefix gcc@12)/include/c++/12/aarch64-apple-darwin23",
               linker-flags: "-L$(brew --prefix gcc@12)/lib/gcc/12"
+            },
+            {
+              cxx: $(brew --prefix llvm@17)/bin/clang++,
+              pkgs: llvm@17 gcc@13,
+              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@13)/include/c++/13 -cxx-isystem $(brew --prefix gcc@13)/include/c++/13/aarch64-apple-darwin23",
+              linker-flags: "-L$(brew --prefix gcc@13)/lib/gcc/13"
+            },
+            {
+              cxx: $(brew --prefix llvm@18)/bin/clang++,
+              pkgs: llvm@18 gcc@14,
+              extra-flags: "-femulated-tls -stdlib=libstdc++ -stdlib++-isystem $(brew --prefix gcc@14)/include/c++/14 -cxx-isystem $(brew --prefix gcc@14)/include/c++/14/aarch64-apple-darwin23",
+              linker-flags: "-L$(brew --prefix gcc@14)/lib/gcc/14"
             }
         ]
 
@@ -40,9 +53,6 @@ jobs:
     - name: setup-compiler
       run: brew update && brew install ${{ matrix.compiler.pkgs }}
 
-    - name: setup-xcode
-      run: sudo xcode-select -switch /Applications/Xcode_15.1.app
-
     - name: setup-catch
       run: sudo bash ../tools/install_catch.sh -DCMAKE_CXX_COMPILER=${{ matrix.compiler.cxx }} -DCMAKE_CXX_FLAGS="${{ matrix.compiler.extra-flags }}" -DCMAKE_EXE_LINKER_FLAGS="${{ matrix.compiler.linker-flags }}"
 
@@ -52,6 +62,9 @@ jobs:
     - name: build
       run: cmake --build . --parallel 8
 
+    - name: run-integration-tests
+      run: ./integration_tests
+
     - name: run-tests
       run: ctest --output-on-failure --schedule-random
 

diff --git a/.github/workflows/sanitizers.yml b/.github/workflows/sanitizers.yml
@@ -4,14 +4,14 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:
         sanitizer: [ address, undefined, thread ]
         include:
-          - cxx: clang++-15
-            pkgs: clang-15 llvm-15
+          - cxx: clang++-18
+            pkgs: clang-18 llvm-18
 
     env:
       ASAN_OPTIONS: check_initialization_order=1:strict_init_order=1:detect_stack_use_after_return=1:detect_leaks=1

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -11,7 +11,10 @@ jobs:
         build-type: [ Release, RelWithDebInfo ]
         platform: [ x64, Win32 ]
         generator: [ "Visual Studio 17 2022" ]
-        compiler: [ v143, ClangCL ]
+        compiler: [ 
+            { name: msvc, toolset: v143 }, 
+            { name: clang, toolset: ClangCL }
+        ]
         build-shared: [ "ON", "OFF" ]
         exclude:
           - platform: Win32
@@ -23,7 +26,7 @@ jobs:
       run:
         working-directory: ${{ github.workspace }}/build
 
-    name: ${{ matrix.compiler }}-${{ matrix.platform }}, ${{ matrix.build-type }}, Shared=${{ matrix.build-shared }}
+    name: ${{ matrix.compiler.name }}-${{ matrix.platform }}, ${{ matrix.build-type }}, Shared=${{ matrix.build-shared }}
 
 
     steps:
@@ -36,14 +39,14 @@ jobs:
     - name: setup-catch
       env:
         CMAKE_GENERATOR: ${{ matrix.generator }}
-        CMAKE_GENERATOR_TOOLSET: ${{ matrix.compiler }}
+        CMAKE_GENERATOR_TOOLSET: ${{ matrix.compiler.toolset }}
         CMAKE_GENERATOR_PLATFORM: ${{ matrix.platform }}
       run: bash ../tools/install_catch.sh
 
     - name: setup-build
       env:
         CMAKE_GENERATOR: ${{ matrix.generator }}
-        CMAKE_GENERATOR_TOOLSET: ${{ matrix.compiler }}
+        CMAKE_GENERATOR_TOOLSET: ${{ matrix.compiler.toolset }}
         CMAKE_GENERATOR_PLATFORM: ${{ matrix.platform }}
       run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DBUILD_SHARED_LIBS=${{ matrix.build-shared }} -DGAPP_USE_WERROR=ON -DGAPP_USE_LTO=ON
 

diff --git a/.iwyu-mappings b/.iwyu-mappings
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -100,15 +100,16 @@ else() # GNU style compiler interface
 
     # gcc specific options
     if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
-	    set(GAPP_WARN_FLAGS "${GAPP_WARN_FLAGS} -Wlogical-op")
+        # -Warray-bounds, -Wstringop-overflow, -Wstringop-overread are regular false positives since g++-12
+	    set(GAPP_WARN_FLAGS "${GAPP_WARN_FLAGS} -Wlogical-op -Wno-array-bounds -Wno-stringop-overflow -Wno-stringop-overread")
     endif()
     # clang specific options
     if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         set(GAPP_OPT_FLAGS "${GAPP_OPT_FLAGS}")
     endif()
 
     set(CMAKE_CXX_FLAGS "${GAPP_CXX_FLAGS} ${GAPP_WARN_FLAGS}")
-    set(CMAKE_CXX_FLAGS_DEBUG "-Og")
+    set(CMAKE_CXX_FLAGS_DEBUG "-Og -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -D_GLIBCXX_ASSERTIONS")
     set(CMAKE_CXX_FLAGS_RELEASE "-g -DNDEBUG ${GAPP_OPT_FLAGS}")
     set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g ${GAPP_OPT_FLAGS}")
 endif()

diff --git a/CMakeSettings.json b/CMakeSettings.json
@@ -103,7 +103,8 @@
       "variables": [
         {
           "name": "CMAKE_CXX_CLANG_TIDY",
-          "value": "clang-tidy"
+          "value": "clang-tidy",
+          "type": "STRING"
         }
       ]
     },

diff --git a/README.md b/README.md
@@ -49,7 +49,7 @@ The maximum of sin(x) in [0.0, 3.14] is at x = 1.57079
 
 The following are needed for building and using the library:
 
-- C++20 compiler (gcc 11.0, clang 14.0, msvc 14.30 or later)
+- C++20 compiler (gcc 11.0, clang 15.0, msvc 14.30 or later)
 - CMake 3.21 or later
 - Catch2 3.3 or later (optional, only needed for the tests)
 

diff --git a/core-guidelines.ruleset b/core-guidelines.ruleset
@@ -24,9 +24,11 @@
 	<!-- Disable rules that are too noisy/not helpful. -->	  
     <Rule Id="C26493" Action="None" /> <!-- Don't use C-style casts. -->
     <Rule Id="C26496" Action="None" /> <!-- The variable 'xyz' is assigned only once, mark it as const. -->
-	<Rule Id="C26814" Action="None" /> <!-- The const variable 'xyz' can be computed at compile time. Use constexpr. -->
+    <Rule Id="C26814" Action="None" /> <!-- The const variable 'xyz' can be computed at compile time. Use constexpr. -->
     <Rule Id="C26812" Action="None" /> <!-- Prefer 'enum class' over 'enum'. -->
-	<Rule Id="C26455" Action="None" /> <!-- Default constructor should not throw. Declare it 'noexcept'. -->
+    <Rule Id="C26455" Action="None" /> <!-- Default constructor should not throw. Declare it 'noexcept'. -->
+    <Rule Id="C26440" Action="None" /> <!-- Function can be declared noexcept. -->
+    <Rule Id="C26447" Action="None" /> <!-- Function declared as noexcept calls potentially throwing function. -->
 
 	<!-- Enable useful rules that are off by default. -->
     <Rule Id="C26815" Action="Warning" /> <!-- The pointer is dangling because it points at a temporary instance that was destroyed. -->

diff --git a/docs/install-guide.md b/docs/install-guide.md
@@ -16,7 +16,7 @@ is needed to build the tests.
 
 The full list of requirements are:
 
-- C++20 compiler (gcc 11.0, clang 14.0, msvc 14.30 or later)
+- C++20 compiler (gcc 11.0, clang 15.0, msvc 14.30 or later)
 - CMake 3.21 or later
 - Catch2 3.3 or later (optional, only needed for the tests)
 

diff --git a/src/algorithm/nd_sort.hpp b/src/algorithm/nd_sort.hpp
@@ -56,8 +56,8 @@ namespace gapp::algorithm::dtl
         constexpr iterator end() const noexcept { return last_; }
 
     private:
-        iterator first_ = {};
-        iterator last_  = {};
+        iterator first_;
+        iterator last_;
     };