Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Label] revisit structure of inner button #640

Open
QuintonJason opened this issue Jul 19, 2021 · 0 comments
Open

[Label] revisit structure of inner button #640

QuintonJason opened this issue Jul 19, 2021 · 0 comments
Labels
P4 Not critical: workarounds exist and/or not a high priority item.

Comments

@QuintonJason
Copy link
Contributor

Description

There are some aspects of how the colors and the mixture of .sage-btn within this component for the secondary button feel potentially leaky. See color settings in loop in _label.scss that override those in _button.scss. We'll need to investigate if there's a need to use SageButton there or if the tradeoff is in our favor to use a custom styled HTML button instead?

Related

  • n/a
@monicawheeler monicawheeler added P4 Not critical: workarounds exist and/or not a high priority item. and removed Sage 3: Tier 4 labels Dec 14, 2021
@philschanely philschanely added this to the TEMP: Backlog milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 Not critical: workarounds exist and/or not a high priority item.
Projects
None yet
Development

No branches or pull requests

3 participants