Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci_reporter_minitest to Gemfile and match h-c-f more closely #936

Merged
merged 1 commit into from
May 8, 2024

Conversation

ianballou
Copy link
Member

Should fix the issue in nightly: [2024-05-07T19:54:51.653Z] Don't know how to build task 'ci:setup:minitest' (see --tasks)

Also made some updates to better match https://github.com/theforeman/hammer-cli-foreman/blob/master/Gemfile

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rubocop failure and are those test failures related?

@ianballou
Copy link
Member Author

I upgraded mini test, this might be the fallout from that. I'll take a look into what needs fixing.

@ianballou ianballou force-pushed the add-ci-reporter-minitest branch from 6430df3 to 24f0939 Compare May 8, 2024 14:31
@ianballou ianballou force-pushed the add-ci-reporter-minitest branch 3 times, most recently from e24cc81 to c855346 Compare May 8, 2024 19:08
@ianballou
Copy link
Member Author

I needed to remove the use of let(:name) due to:

/home/vagrant/hammer-cli-katello/.vendor/ruby/3.0.0/gems/minitest-5.22.3/lib/minitest/spec.rb:253:in `let': let 'name' cannot override a method in Minitest::Spec. Please use another name. (ArgumentError)

@ianballou ianballou force-pushed the add-ci-reporter-minitest branch from c855346 to b937997 Compare May 8, 2024 19:12
@ianballou ianballou force-pushed the add-ci-reporter-minitest branch from b937997 to eea21c5 Compare May 8, 2024 19:16
@ianballou ianballou requested a review from chris1984 May 8, 2024 21:35
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ianballou ianballou merged commit 6d50ad9 into Katello:master May 8, 2024
7 of 10 checks passed
@ianballou ianballou deleted the add-ci-reporter-minitest branch May 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants