Fixes #37865 - Add Multi environments to activation key info

[chris1984]

• Adds support for multi environment activation keys.
• Enabled a test we had skipped since Katello 4.5 that has been fixed for a long time
• Needs this Katello PR to work - Refs #37865 - Add multi cv env rabl to ak and turn off req for name katello#11166

With PR with an ak that has multiple envs:

[vagrant@devel hammer-cli-katello]$ hammer activation-key info --id 36
Name:                           foo-env
Id:                             36
Host Limit:                     0 of Unlimited
Multi Content View Environment: yes
Organization:
 1) Id:   1
    Name: Default Organization
Content view environments:
 1) Content view:
        Id:                      2
        Name:                    Mixed
        Version:                 1.0
        Content view version Id: 2
        Composite:               no
    Lifecycle environment:
        Id:   1
        Name: Library
    Candlepin Name:        Library/Mixed
 2) Content view:
        Id:                      3
        Name:                    Animals
        Version:                 1.0
        Content view version Id: 3
        Composite:               no
    Lifecycle environment:
        Id:   2
        Name: Dev
    Candlepin Name:        Dev/Animals

AK with single env:

[vagrant@devel hammer-cli-katello]$ hammer activation-key info --id 35
Name:                           foo
Id:                             35
Host Limit:                     0 of Unlimited
Multi Content View Environment: no
Organization:
 1) Id:   1
    Name: Default Organization
Content view environments:
 1) Content view:
        Id:                      2
        Name:                    Mixed
        Version:                 1.0
        Content view version Id: 2
        Composite:               no
    Lifecycle environment:
        Id:   1
        Name: Library
    Candlepin Name:        Library/Mixed

[jeremylenz]

What do you think about adding another field like this?

Content View Environments: Library/Mixed,Dev/Animals

This would provide an easy way to copy/paste the current CVEs somewhere so you could edit as needed. It would also need another rabl node added in Katello.

Also it struck me as a bit weird that we don't provide each CVE's id anywhere. do you think we should add that as well? This way it could help with hammer activation-key update --content-view-environment-ids xxx

[chris1984]

What do you think about adding another field like this?

Content View Environments: Library/Mixed,Dev/Animals

This would provide an easy way to copy/paste the current CVEs somewhere so you could edit as needed. It would also need another rabl node added in Katello.

Also it struck me as a bit weird that we don't provide each CVE's id anywhere. do you think we should add that as well? This way it could help with hammer activation-key update --content-view-environment-ids xxx

+1 to those ideas, when you say another rabl node would it go in https://github.com/Katello/katello/blob/bc39167a85e8aaa3ab4285bd459e672c7bcfc7a5/app/views/katello/api/v2/activation_keys/base.json.rabl or somewhere else? It sounds like this is related to that other card

[jeremylenz]

would it go in https://github.com/Katello/katello/blob/bc39167a85e8aaa3ab4285bd459e672c7bcfc7a5/app/views/katello/api/v2/activation_keys/base.json.rabl or somewhere else?

Yes that's the file where it would go. It would be a top-level node.

I'm realizing we already have a node called :content_view_environments which is nested, so it'd have to be called something else. Maybe :content_view_environment_labels

[parthaa]

+1 to those ideas, when you say another rabl node would it go in https://github.com/Katello/katello/blob/bc39167a85e8aaa3ab4285bd459e672c7bcfc7a5/app/views/katello/api/v2/activation_keys/base.json.rabl or somewhere else? It sounds like this is related to that other card

Doesnt need to be in RABL why not just in the info command?

[chris1984]

@jeremylenz updated this pr and the Katello one, when you get time to test it

[jeremylenz]

When I do hammer activation-key list I still see

---|--------|----------------|-----------------------|-------------
ID | NAME   | HOST LIMIT     | LIFECYCLE ENVIRONMENT | CONTENT VIEW
---|--------|----------------|-----------------------|-------------
1  | ak1    | 1 of Unlimited | Library               | cv1         
4  | ak3    | 0 of Unlimited | Library               | cv1         
3  | akZero | 0 of Unlimited |                       |             
---|--------|----------------|-----------------------|-------------

I think we should replace the lifecycle environment and content view columns with 'Content view environments' and use the new field you made. Should also add the 'Multi content view environment' field.

[chris1984]

@jeremylenz updated! Fixed the list command too. Added width 300 to fix long lists of CONTENT VIEW ENVIRONMENTS

---|-----------|----------------|----------------------------|-------------------------------
ID | NAME      | HOST LIMIT     | CONTENT VIEW ENVIRONMENTS  | MULTI CONTENT VIEW ENVIRONMENT
---|-----------|----------------|----------------------------|-------------------------------
3  | multi-key | 0 of Unlimited | Library/RHEL-8,Dev/Animals | yes
2  | RHEL-9    | 1 of Unlimited | Library/RHEL-9             | no
1  | Rocky-8   | 1 of Unlimited | Library/Rocky-8            | no
---|-----------|----------------|----------------------------|-------------------------------

Had to update the license because GPL-3.0 is deprecated and was causing Ruby 3.3 to not build.

[jeremylenz]

LGTM 👍