Fixes #38014 - Add safe navigation for empty capsule content counts #970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
There is an action in Katello that can cause capsule content counts to be an empty hash, we don't safely navigate in Ruby to handle this and hammer blows up with a traceback causing a bad user experience. @sjha4 can probably add more context on how it happens.
Added some unit tests to account for the empty hash and to make sure we handle it correctly
What are the testing steps for this pull request?
foo = SmartProxy.find(X)
foo.content_counts = {}
foo.save