Fixes #36683 - Add help icons to rpm filters #10698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36683 |
|
[test katello] |
sjha4
force-pushed
the
modular_rpm_filter_messages
branch
from
2028e62 to
91c5fe3
Compare
|
[test katello] |
ianballou
reviewed
Sep 12, 2023
webpack/scenes/ContentViews/Details/Filters/MatchContentModal/CVRpmMatchContentModal.js
Outdated
Show resolved
Hide resolved
webpack/scenes/ContentViews/Details/Filters/MatchContentModal/CVRpmMatchContentModal.js
Outdated
Show resolved
Hide resolved
sjha4
force-pushed
the
modular_rpm_filter_messages
branch
from
91c5fe3 to
d7d06f6
Compare
sjha4
force-pushed
the
modular_rpm_filter_messages
branch
from
d7d06f6 to
9279704
Compare
|
The margin of the emptyState should in the matching content modal should be fixed now with the latest commit. |
|
Looking better! |
chris1984
pushed a commit
that referenced
this pull request
Oct 3, 2023
(cherry picked from commit 7bf5ec6)
chris1984
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit 7bf5ec6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Added a few help texts to let users know that RPM filters don't apply to modular packages.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Go to CV > Filters > Create a RPM filter
Add a new filter rule. There should be a new help icon on the modal.
After creating the rule, go to Check matching content in row kebab actions. That modal should also have the help text.
Also updated, empty matching content message to highlight only non-modular packages are matched.