webpack5 #10735
webpack5 #10735
Conversation
| <% if File.exist?("#{Bastion::Engine.root}/vendor/assets/javascripts/#{Bastion.localization_path(I18n.locale)}") %> | ||
| <%= javascript_include_tag(Bastion.localization_path(I18n.locale)) %> | ||
| <% end %> | ||
| <script type="text/javascript"> | ||
| <script type="module"> |
There was a problem hiding this comment.
What defines this type? Is it webpack itself or something else?
There was a problem hiding this comment.
it looked more correct to use module than text/javascript https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules
|
Foreman PR: theforeman/foreman#9834 |
MariaAga
force-pushed
the
webpack5-katello
branch
from
19e0a3a to
a68b8ff
Compare
app/views/overrides/activation_keys/_host_synced_content_select.html.erb
Outdated
Show resolved
Hide resolved
| @@ -10,11 +10,13 @@ | |||
| <% end %> | |||
|
|
|||
| <% content_for(:javascripts) do %> | |||
| <%= javascript_include_tag 'bastion/bastion' %> | |||
|
|
|||
| <%= javascript_tag("window.tfm.tools.loadPluginModule('/webpack/katello','katello','./common_index');".html_safe) %> | |||
There was a problem hiding this comment.
This looks very similar to what js_tags_for(requested_plugins) already does for katello, except that this calls it for common_index and the other does it for index.
I'm trying to understand what common_index.js even does. I don't see anything that includes it and it only requires ngreact. If you don't have this, what happens? If it's needed, can it just be moved into katello's index.js?
There was a problem hiding this comment.
It loads angular, and since angular is not needed in all of Katello I think we shouldn't move it to index.
Without angular pages are just empty.
There was a problem hiding this comment.
That makes sense. Thanks for explaining.
MariaAga
force-pushed
the
webpack5-katello
branch
from
a68b8ff to
3e7a29f
Compare
|
See theforeman/foreman#9834 (comment) If this is ready to go, please create a Redmine. thanks! |
MariaAga
force-pushed
the
webpack5-katello
branch
from
3e7a29f to
5e1820e
Compare
|
looks like angular is failing on eslint |
MariaAga
force-pushed
the
webpack5-katello
branch
from
5e1820e to
c73aade
Compare
|
Core PR was merged, so this should be merged. |
| @@ -14,12 +14,6 @@ class Engine < ::Rails::Engine | |||
|
|
|||
| Bastion.register_plugin( | |||
| :name => 'bastion_katello', | |||
| :javascript => proc do | |||
| [ | |||
| javascript_include_tag(*webpack_asset_paths('katello:common', :extension => 'js'), "data-turbolinks-track" => true), | |||
There was a problem hiding this comment.
This broke the "Sync Status" (/katello/sync_management) page, as the console now contains the following error:
63:2 Uncaught ReferenceError: localize is not defined
There was a problem hiding this comment.
That's an ERB page, I wonder why we're even loading Katello JS here 🤔
Details and discussion here: https://community.theforeman.org/t/resurrection-of-the-client-side-infrastructure-upgrade-effort/32340