Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ENUM type #251

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Drop ENUM type #251

merged 1 commit into from
Mar 14, 2016

Conversation

foxycode
Copy link
Contributor

@foxycode foxycode commented Mar 9, 2016

Related to #250 & #238

I was thinking about completely remove method setDbalTypes and stuff from Connection. Did you implemented it just for types from Kdyby package or will removing brake adding custom types using config?

@fprochazka
Copy link
Member

I was thinking about completely remove method setDbalTypes and stuff from Connection.

The official bundle from doctrine solves it using ConnectionFactory which in fact breaks lazy connection, since databaseplatform is dependent on database version and is created only after doctrine connects to the db (= touching db platform forces connection).

We could try to push this feature to doctrine dbal, so the bundle can use it too. I wouldn't wanna just remove it though.

@fprochazka
Copy link
Member

@foxycode Also, I'm not sure why, but the tests have failed.

@foxycode
Copy link
Contributor Author

@fprochazka Fixed and passing.

@foxycode
Copy link
Contributor Author

@fprochazka Hope now it's ok.

@fprochazka
Copy link
Member

@foxycode great work 👍

fprochazka added a commit that referenced this pull request Mar 14, 2016
@fprochazka fprochazka merged commit 0a3f027 into Kdyby:master Mar 14, 2016
@fprochazka
Copy link
Member

Thank you :)

@foxycode foxycode deleted the drop-enum branch March 14, 2016 13:27
@foxycode foxycode mentioned this pull request Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants