Drop BaseEntity & MagicAccessors & ReadOnlyCollectionWrapper #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add the new package to suggests. |
fprochazka
changed the title
fprochazka
changed the title
fprochazka
force-pushed
the
drop-readonly-collection
branch
from
b307584 to
9d43e34
Compare
| { | ||
|
|
||
| use Kdyby\DoctrineMagicAccessors\MagicAccessors; |
There was a problem hiding this comment.
this is technically a BC Break, but I do not care much, since this will go to 4.0
fprochazka
force-pushed
the
drop-readonly-collection
branch
from
9d43e34 to
c6cd998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Ref #238]