Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Nette 3.0 compatible version #122

Closed
JakubBarta opened this issue May 28, 2019 · 7 comments
Closed

Release Nette 3.0 compatible version #122

JakubBarta opened this issue May 28, 2019 · 7 comments

Comments

@JakubBarta
Copy link

Hi,
it seems everything in master is ready for Nette 3.0. If it's really the case, could you please release Nette 3.0 compatible version?

Thanks!

@enumag
Copy link
Member

enumag commented May 28, 2019

It would be better to make Kdyby/Doctrine independent on this package and deprecate Kdyby/Events. See #97 (comment).

@JakubBarta
Copy link
Author

I see..
Does it mean the last PR (#121) won't be used?
What do you suggest to use instead of this package? https://github.com/contributte/event-dispatcher?

@enumag
Copy link
Member

enumag commented May 28, 2019

Depends on if someone will make the necessary changes for Kdyby/Doctrine. If not then we'll have to stick with Kdyby/Events.

For the future it would be better to migrate your app from Kdyby/Doctrine to Nettrine anyway.

And yes, for events I fully recommend to use contributte/event-dispatcher regardless of what will happen with Kdyby/Events.

@JakubBarta
Copy link
Author

Very well, I'll look into it. Thanks!

@enumag
Copy link
Member

enumag commented May 28, 2019

Actually I think that the master branch of Kdyby/Doctrine already dropped the dependency. So it's all about finishing some other things necessary for Kdyby/Doctrine 4.0. I have long since forgotten the current state of things in that regard but the main discussion was here. It's not exactly necessary to finish all the ideas in this thread, we just need to put the package into some stable state.

@enumag
Copy link
Member

enumag commented May 28, 2019

Making Kdyby/Console optional is a must because the recommended way now is contributte/console (imo). See Kdyby/Doctrine#190.

@enumag
Copy link
Member

enumag commented May 28, 2019

Optional Kdyby/Annotations would be nice too. See Kdyby/Doctrine#268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants