Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable ProofTree tooltips, render them lazily #3510

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

WolframPfeifer
Copy link
Member

@WolframPfeifer WolframPfeifer commented Aug 30, 2024

Trying to solve #3500, this PR does two things:

  • It adds an option to disable the ProofTree tooltips, as requested for example by @unp1 and @mattulbrich. This option can be set in the options of the proof tree (gear icon) as well as in the global menu via "View" -> "Show ProofTree Tooltips" (where the SequentView and SourceView tooltips also can be toggled).
  • A tooltip is now lazily rendered directly when it is needed, not already during creation of the GUITreeNode.

Related Issue

This pull request addresses #3500.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: manual inspection and testing in the GUI
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@WolframPfeifer WolframPfeifer self-assigned this Aug 30, 2024
@WolframPfeifer WolframPfeifer marked this pull request as draft August 30, 2024 17:51
@WolframPfeifer WolframPfeifer added this to the v2.12.3 milestone Aug 30, 2024
@WolframPfeifer
Copy link
Member Author

@unp1 Could you maybe take a quick look whether this PR fixes your performance problems? I can not really reproduce them (at least, KeY does not seem slower than usual to me).

@WolframPfeifer WolframPfeifer marked this pull request as ready for review September 3, 2024 17:37
@WolframPfeifer
Copy link
Member Author

I got the confirmation by @unp1 (thanks for testing!) that this fixes the performance problems, so I merge this now.

@unp1 By the way: I can not reproduce the problems with "Expand/collapse all". For me it works fine, regardless of the other view options which are set ("expand OSS", "hide intermediate", etc.).

@WolframPfeifer WolframPfeifer added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 144a9ba Sep 4, 2024
12 of 13 checks passed
@WolframPfeifer WolframPfeifer deleted the pfeifer/3500lazyProofTreeTooltips branch September 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants