Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 컨트롤바 반응형 디자인 맞춤, 음소거 버튼 구현, 선택한 속도 옆에 보여줌 #342

Conversation

godhyzzang
Copy link
Collaborator

📄 Description of the PR

📸 Screenshots / GIFs (if applicable)

image

✅ Checklist

  • UI 브랜치 같이 확인해서 이슈없는지 확인해보기
  • 함수 이름, 변수 이름만 봐도 어떤 기능을 하는지 파악할 수 있는지 (선언적인 코드인지 확인)

Copy link
Collaborator

@smosco smosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

setPlayBackRate,
} = BasicControlBarProps;

const [previousVolume, setPreviousVolume] = useState(0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음소거 해제할 때 이전 볼륨 크기를 기억하고 있는 거군요!

@smosco smosco merged commit 6154af0 into develop Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] resolve problem controlbar overlaying when responsive design
2 participants