Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 닉네임 유효성 검사 #346

Merged
merged 6 commits into from
Nov 29, 2024
Merged

feat : 닉네임 유효성 검사 #346

merged 6 commits into from
Nov 29, 2024

Conversation

smosco
Copy link
Collaborator

@smosco smosco commented Nov 29, 2024

📄 Description of the PR

🔧 What has been changed?

  • 닉네임 유효성 검사 로직을 추가했어요.

📸 Screenshots / GIFs (if applicable)

⚠️ Precaution & Known issues

✅ Checklist

  • UI 브랜치 같이 확인해서 이슈없는지 확인해보기
  • 함수 이름, 변수 이름만 봐도 어떤 기능을 하는지 파악할 수 있는지 (선언적인 코드인지 확인)

@smosco smosco self-assigned this Nov 29, 2024
godhyzzang
godhyzzang approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@godhyzzang godhyzzang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~ 유효성 검사 굿~ 근데 마이페이지는 toast알림보다는 input태그 밑에 빨간색 글자가 뜨는 편이 좋을 것 같아요
image

@godhyzzang godhyzzang merged commit 41f3b4f into develop Nov 29, 2024
1 check passed
@smosco
Copy link
Collaborator Author

smosco commented Nov 29, 2024

굿유효성 검사 굿 근데 마이페이지는 toast알림보다는 input태그 밑에 빨간색 글자가 뜨는 편이 좋을 것 같아요

이걸 놓쳤군요!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godhyzzang godhyzzang godhyzzang approved these changes

Assignees

@smosco smosco

Labels
🌝 fe ✨ feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] add nickname pattern
2 participants
@smosco @godhyzzang