Skip to content

Commit

Permalink
notif: Rename stream to channel in displayed notifications
Browse files Browse the repository at this point in the history
Fixes: zulip#630
  • Loading branch information
Khader-1 committed May 29, 2024
1 parent 1227390 commit b407423
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/notifications/display.dart
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class NotificationDisplayManager {
FcmMessageStreamRecipient(:var streamName?, :var topic) =>
'$streamName > $topic',
FcmMessageStreamRecipient(:var topic) =>
'(unknown stream) > $topic', // TODO get stream name from data
'(unknown channel) > $topic', // TODO get stream name from data
FcmMessageDmRecipient(:var allRecipientIds) when allRecipientIds.length > 2 =>
zulipLocalizations.notifGroupDmConversationLabel(
data.senderFullName, allRecipientIds.length - 2), // TODO use others' names, from data
Expand Down
2 changes: 1 addition & 1 deletion test/notifications/display_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ void main() {
final stream = eg.stream();
final message = eg.streamMessage(stream: stream);
await checkNotifications(async, messageFcmMessage(message, streamName: null),
expectedTitle: '(unknown stream) > ${message.subject}',
expectedTitle: '(unknown channel) > ${message.subject}',
expectedTagComponent: 'stream:${message.streamId}:${message.subject}');
}));

Expand Down

0 comments on commit b407423

Please sign in to comment.