Handling corrupt unicode on annotation creation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an odd bug! On specific browser, they have noticed that on Label
Studio this gives the following issues:
```
psycopg2.errors.InvalidTextRepresentation: invalid input syntax for
type json
DETAIL: Unicode low surrogate must follow a high surrogate
```
We work around this by doing a round trip to JSON, with
`ensure_ascii=False` will ensure that any UNICODE characters are
preserved, and therefore escaped on the round trip back.
Note: we don't care about any unicode in annotation, as we don't use
the text for referencing our annotation.
Test Plan:
We can reproduce this by forcing the annotation end point to consume unicode.
1. Use the `copy as CURL` option on your browser to copy the "update annotation" call from Label Studio
2. Inject some unicode into the CURL command - e.g.
```
curl 'http://localhost:8080/api/annotations/126?taskID=5979&project=43' \
-X 'PATCH' \
#.... snipped
--data-raw $'{"result":[{"value":{"value":{"start":"/div[1]/div[1]/text()[1]","startOffset":0,"end":"/div[1]/div[1]/text()[1]","endOffset":88,"globalOffsets":{"start":0,"end":88},"text":"Some unicode: \udfff " ...],"draft_id":0,"parent_prediction":null,"parent_annotation":null,"project":"43"}'
```
3. Run it againt the dev server, previously this will cause 500, and with the fix it should 200.
dat-boris
changed the title
lizfaubell
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is an odd bug! On specific browser, they have noticed that on Label
Studio this gives the following issues:
Note: we don't care about any unicode in annotation, as we don't use
the text for referencing our annotation. So let's just remove any unicode
for now to avoid issue with potentially corrupted unicode.
Test Plan:
We can reproduce this by forcing the annotation end point to consume unicode.
Use the
copy as CURLoption on your browser to copy the "update annotation" call from Label StudioInject some unicode into the CURL command - e.g.