feat(LEMS-2664): update use control point and movable point with optional props #1906
+37
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +35 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
anakaren-rojas
commented
Nov 23, 2024
| @@ -47,6 +51,9 @@ export function useControlPoint(params: Params): Return { | |||
| const { | |||
| point, | |||
| sequenceNumber, | |||
| ariaDescribedBy, | |||
| ariaLabel, | |||
| ariaLive = "polite", | |||
There was a problem hiding this comment.
Only removing point or moving out of bounds should be assertive per design doc
anakaren-rojas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
aria label,aria described byandaria livepolite; based on design doc, only the removal of a point or trying to move a point of out bounds warrants the use ofassertivesequenceNumberas a required prop for useControlPoint; If custom aria label is not provided, sequence number and point coordinate will be used as the aria labelIssue: LEMS-2664
Test plan: