This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 746
SoC PolarFire: Add library for 5 PolarFire SoC parts #2843
Open
pthomas
wants to merge
2
commits into
KiCad:master
Choose a base branch
from
pthomas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myfreescalewebpage
added
Addition
Adds new symbols to library
Pending reviewer
A pull request waiting for a reviewer
labels
Jul 7, 2020
myfreescalewebpage
removed
the
Pending reviewer
A pull request waiting for a reviewer
label
Sep 19, 2020
Hello @pthomas Not a full review but some first comments:
Joel |
Add the following parts in SoC_PolarFire.lib: MPFS095T-FCVG484 MPFS160T-FCVG484 MPFS250T-FCVG484 MPFS250T-FCSG536 MPFS250T-FCVG784 MPFS250T-FCG1152 MPFS460T-FCG1152 There are not packages defined for the FCSG536 and FCVG784 parts
@pthomas ping |
Hi Joel,
Thanks for the review, I incorporated the changes into a v2 branch,
but I see everything is on hold until next month.
…-Paul
On Thu, Sep 24, 2020 at 3:29 PM Joel ***@***.***> wrote:
@pthomas ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
You can still push to this PR right now, the repo is locked so we cannot create new pull request, but we merge the maximum of pull request we can by the end of the month. |
OK, Do I just commit to pthomas:master instead of the v2 branch? Should it
be 1 commit or 2?
…-Paul
|
since the previous commit of this PR were on your master branch, do it on your master branch to continue. 1 or 2 commits does not matter |
OK, the master branch is updated, I didn't submit the pull request for
the packages yet, but the two new packages are here:
https://github.com/pthomas/kicad-footprints/tree/polarfire-footprints-v1
Let me know if I need to do anything else.
…-Paul
On Thu, Sep 24, 2020 at 5:33 PM Joel ***@***.***> wrote:
since the previous commit of this PR were on your master branch, do it on your master branch to continue. 1 or 2 commits does not matter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Will perform full review soon, but this is a large PR so it might take a while. |
5 tasks
The names change: BGA-484_19.0x19.0mm_Layout22x22_P0.8mm -> FCVG484_11x11mm_Layout22x22_P0.8mm BGA-1152_35.0x35.0mm_Layout34x34_P1.0mm -> FCG1152_35x35mm_Layout34x34_P1.0mm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following parts in SoC_PolarFire.lib:
MPFS250T-FCVG484
MPFS250T-FCSG536
MPFS250T-FCVG784
MPFS250T-FCG1152
MPFS460T-FCG1152
Folks,
Some may be aware of Microchip's new RISC-V based SoC FPGAs:
https://www.microsemi.com/product-directory/soc-fpgas/5498-polarfire-soc-fpga#overview
Anyway I wanted to get a KiCad library and didn't see anything readily available, so I ended up playing with the tools in kicad-library-utils, and I'm reasonably happy with the result. For each part there is a released Excel spreadsheet in the Packing section of the link below:
https://www.microsemi.com/product-directory/soc-fpgas/5498-polarfire-soc-fpga#resources
Basically using a python script each part is built using the spreadsheets for name references and for the pad location. The ordering and how to break up the units is based both on the symbol in the dev kit schematic[1] and KLC[2]. Here is a listing of the biggest differences from the symbol in the reference schematic:
I put this as an RFC because I know there are a couple of issues and wanted some feedback on other items.
*Packages: Right now none of the parts have packages. This is because there is some python issue with my footprint wizard, and I can't seem to figure out how to use SymbolGenerator.py to set the package anyway.
*Library name: I put it in as a unique library SoC_PolarFire.lib which is very convenient for generating the file. Other name would be fine too.
*NC Pins: if the part had NC pins (not all do) I ended up creating a separate unit and put them all in as non-stacked but invisible. That seemed to satisfy checklib.py, but I'm not sure what is most desired here?
Power pin location: When running checklib.py it complains that "Positive power pins should be placed at top of symbol". This would create a very strange power unit where it's very short and wide with tons of pins on top and a single one on the bottom?
*Power unit: as mentioned above I wasn't completely sure if I did the pin stacking correctly.
I know this is a lot to take in, let me know if there is anything else I can do.
thanks,
Paul
[1] https://www.microsemi.com/document-portal/doc_download/1244587-polarfire-soc-icicle-kit-schematics
[2] https://kicad-pcb.org/libraries/klc/