KCL Boolean Logic (& and |) and keyword parsing fix #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/wasm-lib/tests/executor/inputs/no_visuals/boolean_logical_or.kcl
Outdated
Show resolved
Hide resolved
|
I just changed how AST nodes are serialized, could you please merge/rebase main and then rerun the parser snapshot tests? Your snapshots should be less verbose now. |
This will make our snapshots and JSON representations easier to read (making our tests less verbose).
* Add syntax highlighting for comparison operators * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest) * Confirm --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Neater code, and better error messages.
|
@adamchalmers I'll need you to carry this one |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented boolean logical and (&) and boolean logical or (|). Closes #4188
Fixed a bug in the parsing of keywords; the unambiguous_keywords function looks ahead after a possible keyword candidate for more characters (letters, numbers, -, or _) to see if its an identifier instead of a keyword. This parsing was causing incorrect behavior if there is no token after the word being parsed, e.g. "true" (with EOF afterwards) would be parsed as an identifier because there are no characters to look ahead. This is resolved now.