Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded "Bluemix" URLs #58

Open
christiancompton opened this issue Mar 26, 2019 · 0 comments
Open

Hardcoded "Bluemix" URLs #58

christiancompton opened this issue Mar 26, 2019 · 0 comments

Comments

@christiancompton
Copy link
Collaborator

In some places, bluemix.net is hardcoded. At the minimum, this must be upgraded to cloud.ibm.com, if not removed entirely.

PushSDKCredentials.swift - CloudEnvironment can be used on other cloud providers (esp given OpenShift will be coming…) but in this code I see “bluemix.net” hardcoded - is that supposed to be there?

   guard let host = url.host,
     host.hasSuffix(“.bluemix.net”)
   else{
     return nil
   }
   let parts = host.split(separator: “.”).suffix(3)
   guard parts.count > 2 && parts.first != “imfpush” else {
     return nil
   }
   return parts.joined(separator: “.”)
 }```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant