-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to RegressionVisualization 3D view and volume plot #6
Comments
Also, the plotting in RegressionVisualization requires a CSV input file, and does not seem to be using the input already provided. Do we require this CSV file for plotting or can we reuse the already provided folder, or use the generated Sequence? What do you think? |
@phcredan the sequence is only a series of vtk shapes. The CSV file contains the rest of the information needed to make the graph, namely the volume of the shape observations, and the time interval of the sequence. The interface for "Regression's Input Shapes" can be improved to make this much more clear. For your ideas, I prefer to keep the sequence and volume plot together in the same modules, as the volume plot is very helpful for assessing model fit. What I have added in a recent update is to auto populate the CSV file, since the CSV file will have a known name and will be in the same directory as the one the user chose for the input directory. This way, a user can create the sequence, and then just click plot. |
Sounds good @jamesfishbaugh, could you provide one of those folders with the csv + vtk shapes? I would like to test the plot to help with this issue. |
@phcerdan sure, here is a folder with the input shapes, and an output folder with the sequence and the CSV file. You will have to edit the CSV to modify the paths for your system. |
Thanks @jamesfishbaugh, I got this: Does it look similar to what you get?
Aren't the two lines already too similar?
I agree, will have a look |
@phcerdan There are a couple of issues with the plot, they are very simple:
Could you look into this? |
Yeah, I will put this in my todo list, will find time soon. Thanks for the details. |
@phcerdan thanks. I was actually able to fix the styling, the only thing left is the proper x-axis values:
|
@phcerdan I believe the issue with the plot stems from a bug in the chart. If I change the plot type to 'Scatter', the data is plotted correctly. Do you know where to report this issue? |
Cool, opening an issue in https://discourse.slicer.org/c/dev might help, expose the problem and the differences between the two types. Maybe, who knows, is not a bug, but a feature :) |
I would like to request some small changes to the 3D view and volume plot:
The text was updated successfully, but these errors were encountered: