Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending update: mm2 -> kdf in coins file #2190

Open
smk762 opened this issue Aug 9, 2024 · 7 comments
Open

Pending update: mm2 -> kdf in coins file #2190

smk762 opened this issue Aug 9, 2024 · 7 comments
Labels
priority: high Important tasks that need attention soon.

Comments

@smk762
Copy link

smk762 commented Aug 9, 2024

ref: KomodoPlatform/coins#1121

@smk762 smk762 added the P2 label Aug 9, 2024
@onur-ozkan onur-ozkan added priority: high Important tasks that need attention soon. and removed P2 labels Dec 12, 2024
@onur-ozkan
Copy link
Member

Do we have anything missing in this repo for mm2->kdf replacement?

@cipig
Copy link
Member

cipig commented Dec 12, 2024

Do we have anything missing in this repo for mm2->kdf replacement?

does mm2 still check if the coins/tokens have "mm2": 1 set it coins file?

@onur-ozkan
Copy link
Member

onur-ozkan commented Dec 14, 2024

We haven't change mm2 naming in the RPC payloads yet, in fact we should make a smooth transition for that.

Created an issue to not forget about it: #2293

@cipig
Copy link
Member

cipig commented Dec 14, 2024

We haven't change mm2 naming in the RPC payloads yet, in fact we should make a smooth transition for that.

No need to rename, just remove the param mm2 completely. It wouldn't make a difference anyway, the result would be the exact same, since there are no coins without mm2 param set that also have electrums and everything else needed.

@onur-ozkan
Copy link
Member

We rely on that field for certain logics.

@cipig
Copy link
Member

cipig commented Dec 14, 2024

We rely on that field for certain logics.

what kind of logic? all coins/tokens in current coins file have mm2:1 set, there are no coins without it.

@laruh
Copy link
Member

laruh commented Dec 14, 2024

We rely on that field for certain logics.

As I can see, right mow only EthActivationV2Request structure has mm2 field and we dont use it
image

Also, the adex_cli request structs have it, but we are going to remove this crate, aren't we? and it seems like mm2 field isn't used in adex_cli either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Important tasks that need attention soon.
Projects
None yet
Development

No branches or pull requests

4 participants