-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically managed/self-contained coins file #2268
Comments
i hope it would still be possible to build GUIs with own coins file, eg for tests during integration. atm this happens on build time by using a fork of the coins repo, see https://github.com/cipig/atomicDEX-Desktop/blob/nogeo/CMakeLists.txt#L81 |
Could you plz clarify - who will be making those updates? |
I guess you missed reading the last part of the issue, which says "Users can still manage their own coin files, but this should not be the default approach".
I am not referring to updating the coins file repository; I mean updating the coins file that the KDF uses at runtime. When we make breaking changes to the coins file, new KDF versions will require those updates. This means anyone using the latest KDF versions will have to manually update their coins file, which is really bad in terms of user experience. |
Maybe kdf should fetch latest coins file from https://github.com/KomodoPlatform/coins/blob/master/coins (or from a configurable source) on each start, validate and use. If validation fails, it uses previous coins file. |
I also thought about something similar, with versioning: |
Right now, KDF is expecting for the coins file to be created manually by the user. Because the process is manual, any breaking changes in the coins file directly cause breaking changes in KDF as well (because we need to inform every client that they should update their coins file...). This is a big problem because if the coins file directly impacts KDF's breaking changes, it needs to be managed automatically in a self-contained way.
KDF could create the coins file inside its runtime home directory (which is
~/.kdf
by default) and make updates there. This way, all changes to the coins file would be automatically handled by KDF and breaking changes could be avoided. Users can still manage their own coin files, but this should not be the default approach.The text was updated successfully, but these errors were encountered: