-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please help building version 0.9.0 in a container #116
Comments
@Giszmo Thanks for bringing this to my attention. I will make it a priority to resolve this. We strive for top-notch developer experience (DevEx) at Komodo so thanks for sharing your feedback. |
Please see below for the tagged
|
@CharlVS I need assistance with the CLI build process to reproduce the wallet build. Could you kindly help with this? |
@Shourya742 please share your console output and any other information you can provide. If you have Flutter setup, please also do |
@CharlVS I don't have the Flutter setup on my local machine; instead, I am trying to build the application using a container. I followed the commands provided in the Project Setup guide: https://github.com/KomodoPlatform/komodo-wallet-mobile/wiki/Project-Setup#build-and-run |
Hello @CharlVS
STEPS TO reproduce:
Commands to follow: Build Image: |
@Shourya742 We're working on the Docker builds and will have that ready for you to test tomorrow. Do you want us to include building the API ( |
@CharlVS fetching makes more sense.. Thanks for this. |
If the wallet is split into a library and frontend, both should be reproducible so ideally, yes, we would prefer to also reproduce the library for the purpose of WalletScrutiny.com. We do not build all widely used libraries but this one being controlled by the same provider is clearly of interest. At some point in the future we might get a better grasp of reproducibility of dependencies to split this but for now, if you could please provide a script that builds all artifacts that would be nice. |
@Giszmo, we have docker files for the API artefact here, so I can look into that for you. For the current iteration, we've set up the containers to fetch from the GitHub releases. As of a few hours ago, they're finalised and ready for you and @Shourya742 to test out here. My concern for your review process of building the API artefact from the source is that the binary is built in a non-deterministic way. Hashes won't match and sometimes even vary in size slightly. NB that the container will only run successfully on an x86 machine. ARM support will be added in a future release. If the above is a consideration and you want to compare it to the Play Store APK, please wait until we push a new build within the next week. Previous API artefact releases have had our OPSEC team build the artefacts locally, and then GitHub releases were built from a CI container. Please let me know if you encounter any snags or if there's anything we can do to assist with the review process. |
@Giszmo We're working on adding the artefact compilation to the container. JFYI in case you'd prefer to wait for that to be ready before your review. |
I'll wait. Thanks for the effort. |
@Giszmo, we've got the container set up with PR #147 to build our API artefact and mobile APK. This is an update to show there's progress, so I recommend waiting for it to be merged before proceeding. However, depending on our QA and OPSEC team's availability/priorities, that may still be at least a week or two. |
Hello team Komodo Platform! Danny here, also from walletscrutiny. I was able to build 0.9.1. If, it is approved, it has a verdict of nonverifiable. The diffs:
For your reference, I have included the dockerfile and the script I used. Dockerfile:
com.komodoplatform.sh:
I also ran diffoscope on the files with the diffs which is on the WS MROnce merged, you may run the following,
Thank you! |
Hi team,
I'm trying to reproduce version 0.9.0 and while the version is not tagged, Emanuel identified a likely commit in #60. But ... my attempts to build the product in a reproducible way are so far not successful. Could you please help me build without Android Studio in a container?!
Update 2024-02-09: This app is source-available but despite various comments
on the open issue 60
there is no reaction from the provider.
Emanuel has identified
this commit
as likely candidate for the current version
v0.9.0
on Google Play. Let's seeif we can compile it using the
readme
and
what it points to
...
and that's where we give up for now. The build instructions are geared towards
IDE integration, explaining how to build the project with Android Studio while
we need isolation in a docker container for example and automation via the
command line.
The text was updated successfully, but these errors were encountered: