From a1ff5444866906f3e41cf8210817dcc017a35fb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Grzegorz=20Burzy=C5=84ski?= Date: Mon, 28 Oct 2024 10:52:32 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Patryk Małek --- .../konnect-entities/consumer-and-consumergroup.md | 10 +++++----- .../guides/konnect-entities/key-and-keyset.md | 8 ++++---- .../guides/konnect-entities/service-and-route.md | 6 +++--- .../guides/konnect-entities/tagging-and-labeling.md | 2 +- .../guides/konnect-entities/upstream-and-target.md | 6 +++--- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/app/_src/gateway-operator/guides/konnect-entities/consumer-and-consumergroup.md b/app/_src/gateway-operator/guides/konnect-entities/consumer-and-consumergroup.md index 66765b8f8a5e..c012141a4d37 100644 --- a/app/_src/gateway-operator/guides/konnect-entities/consumer-and-consumergroup.md +++ b/app/_src/gateway-operator/guides/konnect-entities/consumer-and-consumergroup.md @@ -34,7 +34,7 @@ spec: controlPlaneRef: type: konnectNamespacedRef konnectNamespacedRef: - name: gateway-control-plane # KonnectGatewayControlPlane reference + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` @@ -80,7 +80,7 @@ metadata: namespace: default spec: consumerRef: - name: consumer + name: consumer # Reference to the KongConsumer object password: pass username: username ' | kubectl apply -f - @@ -126,7 +126,7 @@ spec: controlPlaneRef: type: konnectNamespacedRef konnectNamespacedRef: - name: gateway-control-plane # KonnectGatewayControlPlane reference + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` @@ -167,12 +167,12 @@ metadata: username: consumer custom_id: 08433C12-2B81-4738-B61D-3AA2136F0212 # Optional consumerGroups: - - consumer-group # KongConsumerGroup reference + - consumer-group # Reference to the KongConsumerGroup object spec: controlPlaneRef: type: konnectNamespacedRef konnectNamespacedRef: - name: gateway-control-plane # KonnectGatewayControlPlane reference + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` diff --git a/app/_src/gateway-operator/guides/konnect-entities/key-and-keyset.md b/app/_src/gateway-operator/guides/konnect-entities/key-and-keyset.md index 07ba2ac85fac..e58b302aaaf4 100644 --- a/app/_src/gateway-operator/guides/konnect-entities/key-and-keyset.md +++ b/app/_src/gateway-operator/guides/konnect-entities/key-and-keyset.md @@ -34,9 +34,9 @@ metadata: namespace: default spec: controlPlaneRef: - type: konnectNamespacedRef + type: konnectNamespacedRef # This indicates that an in cluster reference is used konnectNamespacedRef: - name: gateway-control-plane # KonnectGatewayControlPlane reference + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object kid: key-id name: key pem: @@ -98,7 +98,7 @@ metadata: namespace: default spec: controlPlaneRef: - type: konnectNamespacedRef + type: konnectNamespacedRef # This indicates that an in cluster reference is used konnectNamespacedRef: name: gateway-control-plane # KonnectGatewayControlPlane reference name: key-set @@ -138,7 +138,7 @@ metadata: namespace: default spec: controlPlaneRef: - type: konnectNamespacedRef + type: konnectNamespacedRef # This indicates that an in cluster reference is used konnectNamespacedRef: name: gateway-control-plane # KonnectGatewayControlPlane reference kid: key-id diff --git a/app/_src/gateway-operator/guides/konnect-entities/service-and-route.md b/app/_src/gateway-operator/guides/konnect-entities/service-and-route.md index 71564aa41415..fb555114ea65 100644 --- a/app/_src/gateway-operator/guides/konnect-entities/service-and-route.md +++ b/app/_src/gateway-operator/guides/konnect-entities/service-and-route.md @@ -32,9 +32,9 @@ spec: name: service host: example.com controlPlaneRef: - type: konnectNamespacedRef + type: konnectNamespacedRef # This indicates that an in cluster reference is used konnectNamespacedRef: - name: gateway-control-plane + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` @@ -131,7 +131,7 @@ spec: controlPlaneRef: type: konnectNamespacedRef konnectNamespacedRef: - name: gateway-control-plane # KonnectGatewayControlPlane reference + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` diff --git a/app/_src/gateway-operator/guides/konnect-entities/tagging-and-labeling.md b/app/_src/gateway-operator/guides/konnect-entities/tagging-and-labeling.md index ef8b38838ab9..7b8ef633802a 100644 --- a/app/_src/gateway-operator/guides/konnect-entities/tagging-and-labeling.md +++ b/app/_src/gateway-operator/guides/konnect-entities/tagging-and-labeling.md @@ -71,7 +71,7 @@ spec: controlPlaneRef: type: konnectNamespacedRef konnectNamespacedRef: - name: gateway-control-plane + name: gateway-control-plane # Reference to the KonnectGatewayControlPlane object ' | kubectl apply -f - ``` diff --git a/app/_src/gateway-operator/guides/konnect-entities/upstream-and-target.md b/app/_src/gateway-operator/guides/konnect-entities/upstream-and-target.md index f55e4f8262cf..32c0c7cfa34c 100644 --- a/app/_src/gateway-operator/guides/konnect-entities/upstream-and-target.md +++ b/app/_src/gateway-operator/guides/konnect-entities/upstream-and-target.md @@ -31,7 +31,7 @@ metadata: spec: name: upstream controlPlaneRef: - type: konnectNamespacedRef + type: konnectNamespacedRef # This indicates that an in cluster reference is used konnectNamespacedRef: name: gateway-control-plane # KonnectGatewayControlPlane reference ' | kubectl apply -f - @@ -75,7 +75,7 @@ metadata: namespace: default spec: upstreamRef: - name: upstream # KongUpstream reference + name: upstream # Reference to the KongUpstream object target: "10.0.0.1" weight: 30 --- @@ -86,7 +86,7 @@ metadata: namespace: default spec: upstreamRef: - name: upstream # KongUpstream reference + name: upstream # Reference to the KongUpstream object target: "10.0.0.2" weight: 70 ' | kubectl apply -f -