refactor: remove tailwind utilities in src/view files
#236
Conversation
src/components/ActionsDropdown.vue
Outdated
There was a problem hiding this comment.
I updated the three components in my PR, so maybe we can remove these from this PR to reduce conflicts.
andrewwylde
changed the title
src/view filessrc/view files
andrewwylde
force-pushed
the
fix/remove-tailwind-utilities-view-folder
branch
from
91acd4e to
8958e11
Compare
src/components/ActionsDropdown.vue
Outdated
There was a problem hiding this comment.
@davidma415 I think this still needs float and cursor adjustments from beforetimes
There was a problem hiding this comment.
the .popover class on KPop has float applied. But yeah, looks like I missed cursor pointer on actions-badge class!
| /> | ||
| </div> | ||
| <div class="flex"> | ||
| <div class="buttons-wrapper flex"> |
| /> | ||
| </div> | ||
| <div class="flex"> | ||
| <div class="buttons-wrapper flex"> | ||
| <div class="flex-1"> |
| font-size: 0.875rem; | ||
| line-height: 1.25rem; |
There was a problem hiding this comment.
can we change this to use the design tokens, or the closest values at least? should probably move away from using rem.
src/views/Forbidden.vue
Outdated
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; |
There was a problem hiding this comment.
with h1, .circle these flex styles would be applied to the h1 as well - is this intended? If not, we would want to target .circle separately.
src/views/NotFound.vue
Outdated
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; |
There was a problem hiding this comment.
same comment, i don't think we want to target h1 with the flex styles.
src/views/ProductShell.vue
Outdated
| @@ -1,9 +1,9 @@ | |||
| <template> | |||
| <div class="container flex pb-0 product fixed-position"> | |||
| <div class="product-shell product fixed-position responsive-container"> | |||
There was a problem hiding this comment.
we should remove fixed-position as well.
andrewwylde
merged commit 2a8d731
into
feat/lint-rules-remove-kongponents-utils
No description provided.