Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): disable register when disabled TDX-4796 #532

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

HenriPro
Copy link
Contributor

@HenriPro HenriPro commented Jul 9, 2024

Screenshot 2024-07-09 at 2 42 02 PM

Disables register button and adds tool tip if registration is disabled

@HenriPro HenriPro requested a review from a team as a code owner July 9, 2024 21:45
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


henri pietila seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HenriPro HenriPro changed the title Fix/tdx 4796 disable register fix(spec): disable register when disabled TDX-4796 Jul 9, 2024
@HenriPro HenriPro force-pushed the fix/tdx-4796-disable-register branch from f0ac498 to 5243a98 Compare July 12, 2024 16:34
Copy link
Contributor

@Mierenga Mierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HenriPro HenriPro enabled auto-merge (squash) July 12, 2024 17:56
@HenriPro HenriPro force-pushed the fix/tdx-4796-disable-register branch from 5243a98 to e2305ea Compare July 12, 2024 18:02
@HenriPro HenriPro force-pushed the fix/tdx-4796-disable-register branch from e2305ea to aa6647f Compare July 12, 2024 18:03
@HenriPro HenriPro merged commit 6b0de43 into main Jul 12, 2024
7 checks passed
@HenriPro HenriPro deleted the fix/tdx-4796-disable-register branch July 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants