You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taking a peek at the codebase and strings these days I noticed a lot of inconsistent code syntax style/formatting (e.g., if (thing) vs. if(thing)). Though, I found a stale issue #422 about solving this already.
Additionally I have minor quibbles about certain terminology used in strings along the application. For example, Jar vs. JAR—Oracle and Wikipedia both use the styling of "JAR," so I think using that instead may be more proper. The same could also be said about ZIP, etc.
I also noticed the usage of two periods (..) versus three as a proper ellipses, which also raises the question whether three periods should be used (...), or Unicode's HORIZONTAL ELLIPSIS (…); personally, I like the latter.
Additionally I noticed that there may be some inconsistency with the grammar of translations. For example, in the Vietnamese translation file, many translation strings have a space before the ellipses but not the periods (e.g., "Lưu dưới dạng Zip ..." vs. "Mở..."). There also appear to be un-translated strings as well ("Save As Runnable Jar ..." in vietnamese.json).
I am willing to go through myself and fix the grammar bits, but I'm also curious what you think about code formatting (since #422).
The text was updated successfully, but these errors were encountered:
Hey Nick, if you join our discord so we could chat in more detail about trying to coordinate these changes. (Assuming you're not in there already, I did a quick look to try and DM you, but I didn't see you)
I think these changes are positive but they will require a lot of hands on work, I'd like to be involved in helping with these changes directly if possible.
I believe the majority of the translate inconsistencies came from myself during automatic translations (assuming the base English didn't also have the same mistake). I'd like to help you and solve these grammatical changes.
As for code formatting, that's something I would like to standardize, as well, I know @ThexXTURBOXx has resolved for us in the past but we never standardized that when we did it, so I'm sure we could adopt a standard and enforce it on the project.
Cheers, and thanks for the suggestions! Hopefully we can implement these changes soon, thanks @nick-botticelli!
Taking a peek at the codebase and strings these days I noticed a lot of inconsistent code syntax style/formatting (e.g.,
if (thing)
vs.if(thing)
). Though, I found a stale issue #422 about solving this already.Additionally I have minor quibbles about certain terminology used in strings along the application. For example, Jar vs. JAR—Oracle and Wikipedia both use the styling of "JAR," so I think using that instead may be more proper. The same could also be said about ZIP, etc.
I also noticed the usage of two periods (..) versus three as a proper ellipses, which also raises the question whether three periods should be used (...), or Unicode's HORIZONTAL ELLIPSIS (…); personally, I like the latter.
Additionally I noticed that there may be some inconsistency with the grammar of translations. For example, in the Vietnamese translation file, many translation strings have a space before the ellipses but not the periods (e.g., "Lưu dưới dạng Zip ..." vs. "Mở..."). There also appear to be un-translated strings as well ("Save As Runnable Jar ..." in vietnamese.json).
I am willing to go through myself and fix the grammar bits, but I'm also curious what you think about code formatting (since #422).
The text was updated successfully, but these errors were encountered: